Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Hoist Lints to Workspace #177

Closed
wants to merge 4 commits into from
Closed

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented May 10, 2024

Description

Small pr to hoist crate-level lints to the workspace manifest and references the workspace lint config.

Only rule I've changed is to allow large stack sizes for blobs. If we change clippy's large_stack_size lint to "warn", we'll need to Box the Blob types when passed between scopes.

Copy link
Collaborator Author

refcell commented May 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title chore: hoist lints to workspace chore: Hoist Lints to Workspace May 10, 2024
@refcell refcell requested a review from clabby May 10, 2024 11:17
@refcell refcell added K-chore Kind: chore A-workspace Area: workspace level modifications labels May 10, 2024 — with Graphite App
@refcell refcell self-assigned this May 10, 2024
@refcell refcell marked this pull request as ready for review May 10, 2024 11:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.3%. Comparing base (59e2dd0) to head (a3c2fee).

Files Patch % Lines
crates/derive/src/stages/batch_queue.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell
Copy link
Collaborator Author

refcell commented Jun 11, 2024

Closing in preference for external lint rules

@refcell refcell closed this Jun 11, 2024
@clabby clabby deleted the refcell/chore/hoist-lints branch July 2, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspace Area: workspace level modifications K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants