Add observability to rewind progress #2614
Conversation
JoshdfG
requested review from
dhyaniarun1993,
itschaindev,
sadiq1971,
clabby,
refcell,
emhane and
theochap
as code owners
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoshdfG
force-pushed
the
Add-observability-to-rewind-progress
branch
from
aad6f0c to
0ae5996
Compare
| // Count total blocks to rewind for progress tracking | ||
| let mut total_blocks = 0; | ||
| { | ||
| let mut cursor = self.tx.cursor_read::<DerivedBlocks>()?; | ||
| let mut walker = cursor.walk(Some(block.number))?; | ||
| while let Some(Ok(_)) = walker.next() { | ||
| total_blocks += 1; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
this is too costly for observability logic, which is kind of "secondary logic" if that makes sense. just do latest block number minus target block number
| let mut processed_blocks = 0; | ||
| const LOG_INTERVAL: u64 = 100; | ||
|
|
||
| info!("Starting rewind of {} blocks...", total_blocks); |
There was a problem hiding this comment.
target is missing and pls specify values as key value pairs, see how it's done for other logs. also pls add the target block, the latest block and total number of blocks to walk back.
There was a problem hiding this comment.
@emhane thank you, I have updated the code.
closes: #2593