Skip to content

feat(workspace): Bump MSRV to 1.88 #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

feat(workspace): Bump MSRV to 1.88 #2625

merged 1 commit into from
Aug 1, 2025

Conversation

clabby
Copy link
Member

@clabby clabby commented Aug 1, 2025

Overview

Bumps the MSRV of the workspace to rustc 1.88.

@clabby clabby self-assigned this Aug 1, 2025
@Copilot Copilot AI review requested due to automatic review settings August 1, 2025 18:09
@clabby clabby added K-feature Kind: feature A-workspace Area: workspace level modifications labels Aug 1, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the minimum supported Rust version (MSRV) from 1.86 to 1.88 across the entire workspace. The change affects toolchain configurations, CI workflows, documentation, and includes code modernizations that take advantage of newer Rust features available in version 1.88.

Key Changes

  • Updated MSRV from 1.86 to 1.88 in all configuration files
  • Modernized string formatting using inline format syntax ({var} instead of {:?}, var)
  • Applied const improvements to methods that can be evaluated at compile time
  • Replaced then_some().unwrap_or_default() patterns with cleaner if-else expressions

Reviewed Changes

Copilot reviewed 51 out of 58 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rust-toolchain.toml Updated toolchain channel from 1.86 to 1.88
Cargo.toml Updated workspace rust-version to 1.88
clippy.toml Updated MSRV configuration for clippy
README.md Updated documentation to reflect new MSRV
CLAUDE.md Updated development documentation
.github/workflows/* Updated CI workflows to use Rust 1.88
docker/apps/* Updated Docker image to use Rust 1.88
crates//src/.rs Applied code modernizations using new Rust features
Comments suppressed due to low confidence (4)

rust-toolchain.toml:2

  • Rust version 1.88 does not exist. As of January 2025, the latest stable Rust version is 1.84. Please verify that version 1.88 is available or use a valid version number.
channel = "1.88"

Cargo.toml:4

  • Rust version 1.88 does not exist. As of January 2025, the latest stable Rust version is 1.84. Please verify that version 1.88 is available or use a valid version number.
rust-version = "1.88"

clippy.toml:1

  • Rust version 1.88 does not exist. As of January 2025, the latest stable Rust version is 1.84. Please verify that version 1.88 is available or use a valid version number.
msrv = "1.88"

docker/apps/kona_app_generic.dockerfile:21

  • Rust version 1.88 does not exist. As of January 2025, the latest stable Rust version is 1.84. Please verify that version 1.88 is available or use a valid version number.
ENV RUST_VERSION=1.88

Copy link
Member

@theochap theochap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

/// Finalizes an L2 block
Finalize(FinalizeTask),
Finalize(Box<FinalizeTask>),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: why are we using a Box here? Is that because of versioning or to avoid clones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New clippy lint; The variants have a large difference in size.

@clabby
Copy link
Member Author

clabby commented Aug 1, 2025

Updating the cannon-builder and asterisc-builder images

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 66.15385% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.8%. Comparing base (140d326) to head (4f0ac76).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/supervisor/core/src/supervisor.rs 0.0% 4 Missing ⚠️
crates/node/peers/src/utils.rs 0.0% 2 Missing ⚠️
crates/proof/preimage/src/oracle.rs 0.0% 2 Missing ⚠️
bin/client/src/interop/transition.rs 66.6% 1 Missing ⚠️
crates/node/peers/src/score.rs 0.0% 1 Missing ⚠️
crates/proof/executor/src/builder/assemble.rs 66.6% 1 Missing ⚠️
crates/proof/proof/src/hint.rs 50.0% 1 Missing ⚠️
crates/proof/std-fpvm/src/tracing.rs 0.0% 1 Missing ⚠️
...rotocol/derive/src/stages/batch/batch_validator.rs 0.0% 1 Missing ⚠️
crates/protocol/protocol/src/batch/tx.rs 0.0% 1 Missing ⚠️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clabby
Copy link
Member Author

clabby commented Aug 1, 2025

Needs #2626 + a new release for the FPVM build images.

@clabby clabby force-pushed the cl/msrv-bump-188 branch from dc7a3ba to 752ac99 Compare August 1, 2025 19:37
@clabby clabby force-pushed the cl/msrv-bump-188 branch from 752ac99 to 4f0ac76 Compare August 1, 2025 21:20
@clabby clabby enabled auto-merge August 1, 2025 21:50
@clabby clabby added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit 8bba740 Aug 1, 2025
30 of 31 checks passed
@clabby clabby deleted the cl/msrv-bump-188 branch August 1, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspace Area: workspace level modifications K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants