-
Notifications
You must be signed in to change notification settings - Fork 109
feat(workspace): Bump MSRV to 1.88
#2625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the minimum supported Rust version (MSRV) from 1.86 to 1.88 across the entire workspace. The change affects toolchain configurations, CI workflows, documentation, and includes code modernizations that take advantage of newer Rust features available in version 1.88.
Key Changes
- Updated MSRV from 1.86 to 1.88 in all configuration files
- Modernized string formatting using inline format syntax (
{var}
instead of{:?}, var
) - Applied const improvements to methods that can be evaluated at compile time
- Replaced
then_some().unwrap_or_default()
patterns with cleaner if-else expressions
Reviewed Changes
Copilot reviewed 51 out of 58 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
rust-toolchain.toml | Updated toolchain channel from 1.86 to 1.88 |
Cargo.toml | Updated workspace rust-version to 1.88 |
clippy.toml | Updated MSRV configuration for clippy |
README.md | Updated documentation to reflect new MSRV |
CLAUDE.md | Updated development documentation |
.github/workflows/* | Updated CI workflows to use Rust 1.88 |
docker/apps/* | Updated Docker image to use Rust 1.88 |
crates//src/.rs | Applied code modernizations using new Rust features |
Comments suppressed due to low confidence (4)
rust-toolchain.toml:2
- Rust version 1.88 does not exist. As of January 2025, the latest stable Rust version is 1.84. Please verify that version 1.88 is available or use a valid version number.
channel = "1.88"
Cargo.toml:4
- Rust version 1.88 does not exist. As of January 2025, the latest stable Rust version is 1.84. Please verify that version 1.88 is available or use a valid version number.
rust-version = "1.88"
clippy.toml:1
- Rust version 1.88 does not exist. As of January 2025, the latest stable Rust version is 1.84. Please verify that version 1.88 is available or use a valid version number.
msrv = "1.88"
docker/apps/kona_app_generic.dockerfile:21
- Rust version 1.88 does not exist. As of January 2025, the latest stable Rust version is 1.84. Please verify that version 1.88 is available or use a valid version number.
ENV RUST_VERSION=1.88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
/// Finalizes an L2 block | ||
Finalize(FinalizeTask), | ||
Finalize(Box<FinalizeTask>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking: why are we using a Box here? Is that because of versioning or to avoid clones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New clippy lint; The variants have a large difference in size.
Updating the |
Needs #2626 + a new release for the FPVM build images. |
dc7a3ba
to
752ac99
Compare
752ac99
to
4f0ac76
Compare
Overview
Bumps the MSRV of the workspace to rustc
1.88
.