Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(derive): make tests compile #878

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix(derive): make tests compile #878

merged 1 commit into from
Jan 2, 2025

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Dec 30, 2024

On main, running cargo check -p kona-derive --tests did not work, since the std feature for tracing was not enabled in tests. This enables tracing's std feature when it's a dev dependency.

@refcell refcell added this pull request to the merge queue Jan 2, 2025
Merged via the queue into op-rs:main with commit 9770068 Jan 2, 2025
16 checks passed
This was referenced Jan 2, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@mattsse mattsse mattsse approved these changes

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rjected @mattsse @refcell