-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juanmaturino/edu 23 need to add example of summarizer component for #1022
base: main
Are you sure you want to change the base?
Juanmaturino/edu 23 need to add example of summarizer component for #1022
Conversation
c8c058e
to
6f8953b
Compare
@sharanshirodkar7 Tagging for observability. |
6f8953b
to
76cd381
Compare
@lvliang-intel RFR 🛸 |
c123e37
to
76cd381
Compare
Closing PR Due To Rebasing issues. Will Reopen. |
17becd2
to
7a5d63f
Compare
Reopened PR, after fixing git commit merging errors :) 🚀 🚀 🚀 |
@lianhao can you please review :) |
…prediction guard to repo Signed-off-by: Juan Maturino <[email protected]>
…rd DocSum component reliably returns a response from the user query provided Signed-off-by: Juan Maturino <[email protected]>
…ails how to build, run, and interact with microservice Signed-off-by: Juan Maturino <[email protected]>
Signed-off-by: Juan Maturino <[email protected]>
Signed-off-by: Juan Maturino <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Juan Maturino <[email protected]>
Signed-off-by: Juan Maturino <[email protected]>
7a5d63f
to
6790dab
Compare
messages = [ | ||
{ | ||
"role": "system", | ||
"content": "You are a summarization assistant. Your goal is to provide a very concise, summarized responses of the user query.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lvliang-intel pls review this PR.
From my view, why not merge this with guardrail component we have had? looks like only the prompt and model variant are different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ftian1 Hey Tian,
Hope you're having a good day.
TL;DR: I want to add a document summarization component (PredictionGuard DocSum) to their GenAI Example Repo. This will also allow flexibility in how doc summaries are generated without altering the existing text generation component.
Adding this summarization component, is desired, because it relies on the PredictionGuard platform.
I want to add a PredictionGuard DocSum Permutation to the GenAI Example Repo at some point, and the document summarization component is a necessary component for that MegaService.
You are correct, that this component only differs in the prompt and model from the predictionguard/text-gen component.
Having two separate components allows us to separate concerns if in the future we want to change how docsum is handled by predictionguard, without modifying textgen
adding prediction guard to summarizer component to repo
Description
Addition of Prediction Guard summarization (DocSum) component to opea-project/GenAIComps repo
Issues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Ran the unit tests under tests/llms/...