Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juanmaturino/edu 23 need to add example of summarizer component for #1022

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jjmaturino
Copy link

adding prediction guard to summarizer component to repo

Description

Addition of Prediction Guard summarization (DocSum) component to opea-project/GenAIComps repo

Issues

N/A

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

N/A

Tests

Ran the unit tests under tests/llms/...

@jjmaturino jjmaturino force-pushed the juanmaturino/edu-23-need-to-add-example-of-summarizer-component-for branch 2 times, most recently from c8c058e to 6f8953b Compare December 10, 2024 19:14
@jjmaturino
Copy link
Author

@sharanshirodkar7 Tagging for observability.

@jjmaturino jjmaturino force-pushed the juanmaturino/edu-23-need-to-add-example-of-summarizer-component-for branch from 6f8953b to 76cd381 Compare December 12, 2024 16:12
@jjmaturino
Copy link
Author

@lvliang-intel RFR 🛸

@jjmaturino jjmaturino force-pushed the juanmaturino/edu-23-need-to-add-example-of-summarizer-component-for branch from c123e37 to 76cd381 Compare December 16, 2024 21:19
@jjmaturino
Copy link
Author

Closing PR Due To Rebasing issues. Will Reopen.

@jjmaturino jjmaturino closed this Dec 16, 2024
@jjmaturino jjmaturino reopened this Dec 16, 2024
@jjmaturino jjmaturino force-pushed the juanmaturino/edu-23-need-to-add-example-of-summarizer-component-for branch 2 times, most recently from 17becd2 to 7a5d63f Compare December 16, 2024 21:33
@jjmaturino
Copy link
Author

Reopened PR, after fixing git commit merging errors :) 🚀 🚀 🚀

@jjmaturino
Copy link
Author

@lianhao can you please review :)

jjmaturino and others added 7 commits December 17, 2024 18:01
…prediction guard to repo

Signed-off-by: Juan Maturino <[email protected]>
…rd DocSum component reliably returns a response from the user query provided

Signed-off-by: Juan Maturino <[email protected]>
…ails how to build, run, and interact with microservice

Signed-off-by: Juan Maturino <[email protected]>
Signed-off-by: Juan Maturino <[email protected]>
@jjmaturino jjmaturino force-pushed the juanmaturino/edu-23-need-to-add-example-of-summarizer-component-for branch from 7a5d63f to 6790dab Compare December 18, 2024 00:01
messages = [
{
"role": "system",
"content": "You are a summarization assistant. Your goal is to provide a very concise, summarized responses of the user query.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvliang-intel pls review this PR.

From my view, why not merge this with guardrail component we have had? looks like only the prompt and model variant are different

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ftian1 Hey Tian,

Hope you're having a good day.

TL;DR: I want to add a document summarization component (PredictionGuard DocSum) to their GenAI Example Repo. This will also allow flexibility in how doc summaries are generated without altering the existing text generation component.

Adding this summarization component, is desired, because it relies on the PredictionGuard platform.

I want to add a PredictionGuard DocSum Permutation to the GenAI Example Repo at some point, and the document summarization component is a necessary component for that MegaService.

You are correct, that this component only differs in the prompt and model from the predictionguard/text-gen component.

Having two separate components allows us to separate concerns if in the future we want to change how docsum is handled by predictionguard, without modifying textgen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants