Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lvm comp #1058

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Refactor lvm comp #1058

wants to merge 5 commits into from

Conversation

Spycsh
Copy link
Member

@Spycsh Spycsh commented Dec 23, 2024

Description

Refactor lvm comp

Issues

na

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

na

Tests

UT

@Spycsh
Copy link
Member Author

Spycsh commented Dec 23, 2024

pending this since this targets ww01.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/http_service.py 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/common/component.py 88.09% <100.00%> (ø)
comps/cores/mega/http_service.py 81.91% <75.00%> (-0.31%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant