Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary langsmith dependency #369

Merged
merged 9 commits into from
Aug 18, 2024

Conversation

lvliang-intel
Copy link
Collaborator

Description

Remove unnecessary langsmith dependency

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • [ x ] Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Local test and pre-CI test.

lkk12014402 pushed a commit that referenced this pull request Aug 8, 2024
* Add codegen flowchart

Signed-off-by: Chun Tao <[email protected]>

* update flowchart to markdown format

Signed-off-by: Chun Tao <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update markdown diagram

Signed-off-by: Chun Tao <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

Signed-off-by: Chun Tao <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* delete last line

Signed-off-by: Chun Tao <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add flowchart for CodeGen, update readme

Signed-off-by: Chun Tao <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* udpates

Signed-off-by: Chun Tao <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Chun Tao <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@chensuyue chensuyue added this to the v0.9 milestone Aug 17, 2024
@chensuyue chensuyue merged commit cc8cd70 into opea-project:main Aug 18, 2024
38 checks passed
srinarayan-srikanthan pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 21, 2024
tileintel pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 22, 2024
Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: siddhivelankar23 <[email protected]>
@eero-t
Copy link
Contributor

eero-t commented Aug 28, 2024

@lvliang-intel One langsmith dependency + import remain:

$ git grep langsmith
comps/agent/langchain/requirements.txt:langsmith
comps/embeddings/neural-speed/embedding_neuralspeed_svc.py:from langsmith import traceable

Were these left on purpose?

sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants