Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix list_service method not returning expected response (#787) #788

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

isaacncz
Copy link
Contributor

@isaacncz isaacncz commented Oct 11, 2024

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.
#787

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/gateway.py 0.00% 9 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/mega/micro_service.py 83.05% <100.00%> (+0.14%) ⬆️
comps/cores/mega/gateway.py 29.82% <0.00%> (-0.43%) ⬇️

@isaacncz
Copy link
Contributor Author

isaacncz commented Nov 7, 2024

Hi @lvliang-intel, please review and close PR

@chensuyue chensuyue merged commit 3401db2 into opea-project:main Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants