Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable milvus for retriever and data-preparation #858

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xiguiw
Copy link
Collaborator

@xiguiw xiguiw commented Nov 6, 2024

Enable milvus vector database work with TEI embedding for retriever and data-preparation

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

opea-project/GenAIExamples#886

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

Milvus vector database was added in OPEA.
No newly introduced 3rd party dependency.

Tests

Verify retrieval and data-preparaton upload/deletefile
Combined with ChatQnA UI verification the RAG functionality.

@xiguiw
Copy link
Collaborator Author

xiguiw commented Nov 7, 2024

Hi @chensuyue,

Both retrieval-miluvs and data-preparation-milvus are working with TEI embedding now, which is widely used by GenAIExamples.

From the MicroService-test logs, it seems the test set the MOSEC_EMBEDDING environment instead of
TEI_EMBEDDING_ENDPOINT.

INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://0.0.0.0:6007/ (Press CTRL+C to quit)
[2024-11-07 02:09:59,991] [    INFO] - Base service - HTTP server setup successful
[2024-11-07 02:09:59,994] [    INFO] - prepare_doc_milvus - [ prepare_doc_milvus ] MOSEC_EMBEDDING_ENDPOINT:http://100.80.243.74:5021,/ MOSEC_EMBEDDING_MODEL:/home/user/bge-large-zh-v1.5
+ '[' 000 -ne 200 ']'
+ echo '[ dataprep_del ] HTTP status is not 200. Received status was 000'
+ [[ dataprep_del == *\d\a\t\a\p\r\e\p\_\u\p\l\o\a\d\_\l\i\n\k* ]]
+ exit 1
[ dataprep_del ] HTTP status is not 200. Received status was 000
Error: Process completed with exit code 1.

@yinghu5 yinghu5 self-requested a review December 2, 2024 07:51
@xiguiw xiguiw force-pushed the enable-milvus branch 3 times, most recently from d4dc50c to 045a056 Compare December 6, 2024 03:45
xiguiw and others added 2 commits December 6, 2024 11:47
Enable milvus vector database work with TEI embedding
for retriever and data-preparation

Signed-off-by: Wang, Xigui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant