Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Fix tip of the branch to work with latest DocSum microservice changes #901

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashahba
Copy link
Collaborator

@ashahba ashahba commented Nov 14, 2024

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@ashahba ashahba added the WIP label Nov 14, 2024
@ashahba ashahba changed the title Fix tip of the branch to work with latest DocSum microservice changes WIP - Fix tip of the branch to work with latest DocSum microservice changes Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/gateway.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/mega/gateway.py 28.14% <0.00%> (ø)

🚨 Try these New Features:

@eero-t
Copy link
Contributor

eero-t commented Dec 18, 2024

@ashahba There's no gateway.py anymore. Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants