Skip to content

Add version info and appstream metadata for AppImage #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SkyBird233
Copy link

Include versioning information and appstream metadata for the Animeko AppImage.

@Him188 Him188 requested a review from WoLeo-Z June 7, 2025 18:36
Copy link
Member

@WoLeo-Z WoLeo-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@WoLeo-Z WoLeo-Z requested a review from Him188 June 8, 2025 01:56
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

域名可以直接使用 animeko.org ,方便改一下吗

@SkyBird233
Copy link
Author

已修改。以及 description 部分可能偏简略了,但不太确定怎么写合适,可能需要您们定夺?

@StageGuard
Copy link
Member

StageGuard commented Jun 10, 2025

我们现在已经有了三个所谓的 app id:

  • 此 PR 中的 org.myani.animeko
  • Android me.him188.ani
  • iOS org.openani.Animeko

虽然它们之间没什么关系,但我并不认为有这么多 id 是一件好事,我建议统一使用包名 me.him188.ani @Him188

@Him188
Copy link
Member

Him188 commented Jun 10, 2025

我更想使用 animeko.org 来着,如果有机会改的话

@SkyBird233
Copy link
Author

这个 PR 使用 org.myani.animeko 的原因是参考 AppStream 的元数据规范使用了 {tld}.{vendor}.{product} 格式,其中 org.myani 部分来源是 GitHub 仓库信息给的链接 https://myani.org/ ,提交时并不了解 animeko.org 这一域名

我的想法是如果要统一 ID 的话可能需要更多讨论,因为对于 Android 和 iOS 要改掉包名对用户来说都有不小影响?如果要使用 animeko.org 的话,根据规范这个 PR 里的 ID 相关部分应该改为使用 org.animeko.animeko

@Him188

@Him188
Copy link
Member

Him188 commented Jun 10, 2025

ok, 那我们采用 org.openani.animeko 吧

安卓平台和现有 PC 平台的不容易改了, 数据会不兼容. 至少要等以后出云设置同步后才能做.

@Him188 Him188 requested a review from StageGuard June 10, 2025 15:52
@SkyBird233 SkyBird233 force-pushed the feat-appimage-improvement branch from d2e9a85 to 037f2d6 Compare June 10, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants