new particle_shape_and_density #1539
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pended particle attributes
slayoo
requested changes
Mar 19, 2025
| @staticmethod | ||
| def mass_to_volume(const, mass): | ||
| return ( | ||
| Trivia.volume_of_density_mass(const, const.rho_i, mass) |
There was a problem hiding this comment.
Unfortunately, this will not work with the current implementation of Formulae. Everything in the physics folder is expected to take form of one-liners without calls to other than NumPy math functions. It will choke both in the GPU backend (where Trivia. will not work in C code), but likely also in Numba CPU backend for it does not allow non-Numba class accessors.
| @staticmethod | ||
| def area(const, radius): | ||
| return const.PI * const.FOUR * np.power(radius, const.TWO) | ||
|
|
||
| @staticmethod | ||
| def volume(const, radius): | ||
| def sphere_radius_to_volume(const, radius): |
| def __init__(self, const, _): | ||
| pass | ||
|
|
||
| @staticmethod |
There was a problem hiding this comment.
It seems that supports_mixed_phase within IceSpheres does not really convey much - should always be True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concept for new handling of particle attributes depended on shape (area, volume, mass, capacity...)
common parent class of spheres for liquid and ice spheresI realize that the use of static methods in the spheres class and definition to self.mass density in the initiation of sub classes, liquid and ice spheres, does not make much sense in the current iterationIn the future, we could move to a logic where the shape is assigned (and can be changed!) for all super particles individually instead of separating them into just two (liquid and ice) particles. However, more 'fancy' shape realtionships like shape habit prediction could also be used with the current seperation intwo two types