Skip to content

ventilation: new example based on fig. 1 from Stewart 1975 (and including data from Kinzer & Gunn 1951) #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slayoo merged 27 commits into from
Apr 19, 2025
Merged

ventilation: new example based on fig. 1 from Stewart 1975 (and including data from Kinzer & Gunn 1951) #1556

slayoo merged 27 commits into from
Apr 19, 2025

Conversation

@AgnieszkaZaba
Copy link
Collaborator

@AgnieszkaZaba AgnieszkaZaba commented Mar 26, 2025 •
edited by slayoo
Loading

Addresses the issue #1551
It is just a starting point for work on this.

TODO:

  • populate tables 1 and 2 (Kinzer&Gunn 1951) and move to separate folder for this paper
  • add formula for calculating F
  • ventilation coefficient from PruppacherAndRasmussen1979
  • add tests

@AgnieszkaZaba AgnieszkaZaba marked this pull request as draft March 26, 2025 23:26
@AgnieszkaZaba AgnieszkaZaba self-assigned this Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (62c152e) to head (02a9dac).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         392      392           
  Lines        9530     9530           
=======================================
  Hits         8141     8141           
  Misses       1389     1389

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AgnieszkaZaba AgnieszkaZaba marked this pull request as ready for review April 16, 2025 12:35
slayoo
slayoo requested changes Apr 16, 2025
View reviewed changes
Copy link
Member

@slayoo slayoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!
just a few totally minor comments

@slayoo slayoo changed the title New example Stewart 1975 ventilation: new example based on fig. 1 from Stewart 1975 (and including data from Kinzer & Gunn 1951) Apr 16, 2025
@slayoo slayoo linked an issue Apr 16, 2025 that may be closed by this pull request
new example: Fig 1 from Stewart 1975 (ventilation factor vs. drop radius) #1551
Closed
@AgnieszkaZaba AgnieszkaZaba requested a review from slayoo April 17, 2025 13:21
slayoo
slayoo requested changes Apr 17, 2025
View reviewed changes
@slayoo slayoo added this pull request to the merge queue Apr 19, 2025
Merged via the queue into open-atmos:main with commit e0efb42 Apr 19, 2025
191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slayoo slayoo slayoo approved these changes

Assignees

@AgnieszkaZaba AgnieszkaZaba

Labels

isotopes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new example: Fig 1 from Stewart 1975 (ventilation factor vs. drop radius)

2 participants

@AgnieszkaZaba @slayoo