ventilation: new example based on fig. 1 from Stewart 1975 (and including data from Kinzer & Gunn 1951) #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… first columns of Kinzer&Gunn1951 tables
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
=======================================
Coverage 85.42% 85.42%
=======================================
Files 392 392
Lines 9530 9530
=======================================
Hits 8141 8141
Misses 1389 1389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slayoo
requested changes
Apr 16, 2025
Member
slayoo
left a comment
slayoo
left a comment
There was a problem hiding this comment.
THANK YOU!
just a few totally minor comments
slayoo
changed the title
slayoo
requested changes
Apr 17, 2025
slayoo
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue #1551
It is just a starting point for work on this.
TODO:
F