Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal velocity of ice particles #1562

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

terminal velocity of ice particles #1562

wants to merge 13 commits into from

Conversation

tluettm
Copy link
Collaborator

@tluettm tluettm commented Apr 1, 2025 •
edited
Loading

TODOs:

  • change dependency settings for terminal velocity of ice
  • refactor names of methods in terminal velocity backend for clarity
  • check if (more) unit tests for particle displacement need to be changed to test displacment of ice particles
  • Solve problem: terminal velocity of liquid particles overwrites terminal velocity of ice particles. Hence order of function call matters.
  • implement parameterisation for drag coefficient of smooth spheres for intermediate and large reynold numbers

tluettm added 13 commits March 18, 2025 16:06
@tluettm
modified sedimentation unit test to test for ice particles
bdc1fd8
@tluettm
added empirical parametrisation for columnar ice crystals
3745b92
@tluettm
added atmospheric correction factor for columnar ice crystals termina…
e7f8fee 
…l velocity
@tluettm
name change of columnar ice crystal sedimentation class
4901282
@tluettm
changed mass attribute to signed mass attribute for relative fall vel…
599c408 
…ocity
@tluettm
separated ice and liquid terminal velocity classes
99c4100
@tluettm
added check for negative radius (indicating ice mass) to RogersYau an…
d111cce 
…d GunnKinzer terminal velocity
@tluettm
further work on columnar ice crystal terminal velocity and added a un…
13fbcd3 
…it test
@tluettm
added temperature and pressure dependence for columnar ice crystal te…
43b35db 
…rminal velocity
@tluettm
added todo
c185563
@tluettm
Merge branch 'main' into ice_sedimentation
c6bc099 
Merged main into ice sedimentation development.
@tluettm
added terminal velocity for smooth ice spheres
62e1192
@tluettm
added new unit test for terminal velocity of ice particles
8b7557f
@slayoo slayoo added the ice label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tluettm @slayoo