chore: update workflow to download and extract OCM CLI alongside CTF #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: Gerald Morrison (SAP) <[email protected]> Signed-off-by: Gerald Morrison (SAP) <[email protected]>
On-behalf-of: Gerald Morrison (SAP) <[email protected]> Signed-off-by: Gerald Morrison (SAP) <[email protected]>
… inputs On-behalf-of: Gerald Morrison (SAP) <[email protected]> Signed-off-by: Gerald Morrison (SAP) <[email protected]>
On-behalf-of: Gerald Morrison (SAP) <[email protected]> Signed-off-by: Gerald Morrison (SAP) <[email protected]>
| @@ -28,40 +28,25 @@ jobs: | |||
| with: | |||
| repository: open-component-model/ocm | |||
| ref: main | |||
| # Download OCM CLI from GH release assets | |||
| - name: Install OCM CLI | |||
There was a problem hiding this comment.
why are you changing this to not use the shipped cli version?
There was a problem hiding this comment.
the action anyway uses "released" GH assets for the CTF as we're after the release to GH, so I download everything required from the same released asset set (using curl for the CTF and our GH action for the CLI)
…and triggers On-behalf-of: Gerald Morrison (SAP) <[email protected]> Signed-off-by: Gerald Morrison (SAP) <[email protected]>
…n token lifetime and usage On-behalf-of: Gerald Morrison (SAP) <[email protected]> Signed-off-by: Gerald Morrison (SAP) <[email protected]>
… for cleaner output On-behalf-of: Gerald Morrison (SAP) <[email protected]> Signed-off-by: Gerald Morrison (SAP) <[email protected]>
|
if PRs don't have an issue linked, I still believe you should add them to the project board... otherwise you'll probably forget them, right? |
|
If prs dont have an issue, it is time for an issue :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On-behalf-of: Gerald Morrison (SAP) [email protected]
Signed-off-by: Gerald Morrison (SAP) [email protected]
What this PR does / why we need it
update workflow to download and extract OCM CLI alongside CTF