-
Notifications
You must be signed in to change notification settings - Fork 34
ITEP-73107: fix CVE-2025-4565 in Controller image #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdanieck
commented
Aug 1, 2025
| # WORKAROUND: Force upgrade protobuf to a secure version, even though vdms pins an older version. | ||
| # This may break vdms if it is not compatible with newer protobuf, but is required to fix CVE-2025-4565. | ||
| # Remove this when vdms supports a secure protobuf version. | ||
| RUN pip3 install --break-system-packages --upgrade --no-cache-dir 'protobuf>=4.25.8' |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjarquin I was given your name by @tdorauintc. Is there any way you can help us with vdms update ?
Irakus
approved these changes
Aug 1, 2025
tdorauintc
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Trivy image scan discovered CVE-2025-4565 in the Controller image. The protobuf package is pulled in indirectly by vdms.
The proper fix requires protobuf dependency update in the vdms and vdms upgrade on our side. Looking at the vdms repo we can see both the IntelLabs/vdms#298 issue and the IntelLabs/vdms#299 PR which are not resolved since Jun 17.
This PR overrides the protobuf package after vdms installation. Minor version upgrade is expected to be backward compatible, hence it should be safe to upgrade. That said it requires running regression tests on our end to make sure everything is still working fine.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: