-
Notifications
You must be signed in to change notification settings - Fork 452
Add DoRA support for ViT classification model. #4466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
src/otx/backend/native/models/classification/backbones/vision_transformer.py
Outdated
Show resolved
Hide resolved
src/otx/backend/native/models/classification/backbones/vision_transformer.py
Outdated
Show resolved
Hide resolved
src/otx/backend/native/models/classification/multilabel_models/vit.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gyuilLim thanks for your efforts! Could you add a brief version of the table with results of the experiments? That'd be useful in the future, so everyone can see the impact of the PR by simply looking at description.
Also, the PR doesn't contain any tests. Newly added modules should be covered with unit tests. It'd be good to check that peft parameter actually works, like Kirill said. It might be enough to check if a multiclass cls ViT model can be created and forwarded with peft not None. Actual training seems to be a bit redundant and we have don't have a redy-to-use location to store that kind of tests
@sovrasov Thank you! I'll add unit tests.
|
Summary
Added DoRA support and replaced
lora
falg withpeft
argument usingLiteral["lora", "dora"]
.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.