Skip to content

Improve EarlyStoppingWithWarmup docs and set check_on_train_epoch_end to False as default #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eugene123tw
Copy link
Contributor

Summary

This PR improves EarlyStoppingWithWarmup callback documentation and sets check_on_train_epoch_end to False by default to avoid double counting on both train and validation epoch ends, preventing unexpectedly early training termination.

  • Added unit test for EarlyStoppingWithWarmup callback

How to test

  • Tests cover both unit functionality and integration scenarios

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

- Set default value for check_on_train_epoch_end to False in EarlyStoppingWithWarmup.
@eugene123tw eugene123tw changed the base branch from develop to release/2.5 July 21, 2025 13:17
@github-actions github-actions bot added the TEST Any changes in tests label Jul 21, 2025
@eugene123tw eugene123tw requested a review from kprokofi July 21, 2025 13:36
@kprokofi kprokofi merged commit c383371 into open-edge-platform:release/2.5 Jul 21, 2025
14 checks passed
@eugene123tw eugene123tw deleted the eugene/improve/early-stopping-warmup-docs-and-tests branch July 22, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants