[WIP] [Attestation-Manager] Adding drain node feature #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sholapur, Prashant <[email protected]>
lsubash
changed the title
vtcao297
reviewed
Apr 22, 2025
| // } | ||
| config, err := rest.InClusterConfig() | ||
| if err != nil { | ||
| logging.Error("Error building in-cluster config: %s", err.Error()) |
There was a problem hiding this comment.
return false due to error? also after line 46 also
vtcao297
reviewed
Apr 22, 2025
| } else { | ||
| return true | ||
| } | ||
|
|
vtcao297
reviewed
Apr 22, 2025
| } | ||
| logging.Debug("Node cordoned successfully") | ||
| // Sleep for a while before the next attestation check | ||
| logging.Debug("Sleeping for 1 minutes and calling drainNode()") |
There was a problem hiding this comment.
why is there a need to sleep for 1 minute before draining the node? seems arbitrary
vtcao297
reviewed
Apr 22, 2025
| } | ||
|
|
||
| func cordonNode(clientset *kubernetes.Clientset, nodeName string) error { | ||
| node, err := clientset.CoreV1().Nodes().Get(context.TODO(), nodeName, metav1.GetOptions{}) |
There was a problem hiding this comment.
will these context.TODO() be replaced with other more appropriate context to handle cancellations, timeouts, and data passing, etc? It's recommended to never use context.TODO() in production code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Fixes # (issue)
Any Newly Introduced Dependencies
How Has This Been Tested?