-
Notifications
You must be signed in to change notification settings - Fork 5
feat: update electricity demand profiles #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
) Bumps the github-actions group with 1 update: [lkstrp/pypsa-validator](https://github.com/lkstrp/pypsa-validator). Updates `lkstrp/pypsa-validator` from 0.2.3 to 0.2.4 - [Release notes](https://github.com/lkstrp/pypsa-validator/releases) - [Commits](PyPSA/pypsa-validator@v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: lkstrp/pypsa-validator dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add retrieve rule and script to retrieve TYNDP data bundle from Zenodo * Improve doc string * Add data retrieve as default for tyndp * Shorten folder name --------- Co-authored-by: daniel-rdt <[email protected]>
) * add initial structure and script for tyndp data cleaning * add loading and prep of electricity demand * Fix naming convention and formatting * Use snapshot year as electricity demand and climatic year are correlated * Add a fallback option if snapshot year is not available in TYNDP data * Write output file in resources and match naming convention * Add parameters for the scenarios * Add more documentation * Shorten naming convention * Address data inconsistencies in electricity profiles --------- Co-authored-by: daniel-rdt <[email protected]>
daniel-rdt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tgilon! Good catch with the UK / GB load! I also validated the load again on a yearly total load per country basis and it passes the assertion locally. Should we maybe introduce an assertion unit test for this into the workflow based on your validation notebook?
coroa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, a few small improvements and questions, i do still have :)
|
Re: Heating demand. It would be better if we can deactivate the heating demand with some heating specific settings (since this can then also avoid calculating all the heat pump profiles and temperature dependent heat demand inputs). |
|
Maybe we need to add a sort of validate config step during which incompatible settings are raising. Out of scope for this PR. |
I thought about it. Since we need the output of |
|
So, nothing here is blocking anymore in my opinion. I would like that the And before the final tyndp release we are aiming for some sort of config validation, which complains if incompatible settings are chosen. |
Co-authored-by: Jonas Hörsch <[email protected]>
|
After discussing with @coroa and @daniel-rdt, I will use the |
|
@coroa @daniel-rdt Here is a summary of what I did:
All of this is documented in #43. |
for more information, see https://pre-commit.ci
Closes #6.
Changes proposed in this Pull Request
This PR suggests to add options in PyPSA-Eur to use the custom electricity demand profiles of TYNDP.
The feature can be tested with:
Tasks
UKorGBshould be usedbuild_shapesadd_electricityandprepare_sector_networkby @tgilonbuild_electricity_demand_baseprepare_sector_networkadd_biomassprepare_sector_networkadd_industrybased onheatingsector switchpop_layoutand low-voltage nodes forLUF1andLUG1build_electricity_demandbuild_electricity_demand(should not be allowed)make tyndpplanning_horizonswildcardWorkflow
retrieve_tyndp_bundleoutputsto add electricity demand dataclean_tyndp_databuild_electricity_demand(electricity) andprepare_sector_network(other carriers - will be covered later)build_electricity_demandand (new)build_electricity_demand_tyndpdata/electricity_demand_raw.csv(OPSD data) anddata/load_synthetic_raw.csv(demand calculator) are used.electricity_demand.csvfrom PyPSA-Eur is a CSV file with hourly resolution data as rows and countries as columns. TYNDP electricity demand profiles have climate years as columns and tabs for each node. Electricity demand data varies across planning years (hence the need for theplanning_horizonswildcard for TYNDP demand-related rules).build_electricity_demand_baserule to work with it.build_electricity_demand_baseand (new)build_electricity_demand_base_tyndpplanning_horizonswildcard in the TYNDP casecluster_networkresources/electricity_demand_base_s.ncan optional input as electrical load is used for clusteringadd_electricityplanning_horizonswildcard. Attached inprepare_sector_network.prepare_sector_networkplanning_horizons).add_existing_baseyear. To be addressed by Implementation of hybrid heat pumps & removal of other technologies #3use_industry_loadis introduced for modelling Industrial electricity demand explicitly. This is disabled for TYNDP load.add_existing_baseyearChecklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.doc/data_sources.rst.doc/release_notes.rstis added.