Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badges for configuration/acquisition properties #126

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Oct 29, 2024

This does not have an effect until #108 is merged
Resolves #30

@cjsha cjsha added this to the Infrastructure milestone Oct 29, 2024
@cjsha cjsha requested a review from bparks13 October 29, 2024 05:11
@bparks13
Copy link
Member

Is the only place that we define the categories in the Getting Started page? It might be confusing for someone to use F1 help and see these tags but not fully understand what they mean.

Is it possible to hyperlink these tags to go to the Property Categories page?

@cjsha
Copy link
Member Author

cjsha commented Oct 29, 2024

yeah we can do that. and/or we can do what github does which is a tooltip shows up when hovering over a badge

@bparks13
Copy link
Member

Tool tip might work, as long as we can have a single source of truth that the webpage and the tooltip are both pulling from so they don't get desynchronized

@cjsha
Copy link
Member Author

cjsha commented Oct 29, 2024

couldn't get a nice tooltip going. instead I made an issue #130 and put tooltip in the wishlist category. The tags are hyperlinked

Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested this by merging with main locally to see the badges pop up, and the hyperlinks worked for me.

@bparks13 bparks13 merged commit 409a498 into main Oct 31, 2024
3 checks passed
@bparks13 bparks13 deleted the issue-30 branch October 31, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorize properties into "Configuration Property" or "Acquisition Property" categories.
2 participants