-
Notifications
You must be signed in to change notification settings - Fork 85
feat: Add support for HTTP eTag header and 304 no change response #1645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add support for HTTP eTag header and 304 no change response #1645
Conversation
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cf5af70
to
747c879
Compare
Signed-off-by: Zhiwei Liang <[email protected]>
Signed-off-by: Zhiwei Liang <[email protected]>
Signed-off-by: Zhiwei Liang <[email protected]>
bbe70e9
to
fc61a8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, this is a really great addition. We should also update the readme, to inform people about this behavior, as this might not be as obvious at the beginning
@aepfli Thank you for the suggestion! May I know which README should be changed? The one in the root directory of the repository doesn't seem to be describing sync behaviors? |
@ChihweiLHBird, it may be worth mentioning the eTag behavior here. Thanks! |
I'll merge this now since it should be transparent to end users. |
This PR
eTag
request header and304 Not Modified
response.Related Issues
Fixes #1558
Notes
This proposal includes some significant behavior changes; therefore, any feedback, opinions, or objections are welcome and appreciated.
How to test
More specific test cases to be added when we all agree on proceeding with the implementation of the change in this PR.