Skip to content

feat: Add support for HTTP eTag header and 304 no change response #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ChihweiLHBird
Copy link
Contributor

@ChihweiLHBird ChihweiLHBird commented Jun 21, 2025

This PR

  • adds the support for the eTag request header and 304 Not Modified response.

Related Issues

Fixes #1558

Notes

This proposal includes some significant behavior changes; therefore, any feedback, opinions, or objections are welcome and appreciated.

How to test

make build
cd bin && ./flagd start --port 8013 --uri https://raw.githubusercontent.com/open-feature/flagd/main/samples/example_flags.flagd.json --debug

More specific test cases to be added when we all agree on proceeding with the implementation of the change in this PR.

@ChihweiLHBird ChihweiLHBird changed the title Add support for HTTP eTag header and 304 no change response feat: Add support for HTTP eTag header and 304 no change response Jun 21, 2025
Copy link

netlify bot commented Jun 21, 2025

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 1ca9e7a
🔍 Latest deploy log https://app.netlify.com/projects/polite-licorice-3db33c/deploys/68714eac599c1f00082e9493
😎 Deploy Preview https://deploy-preview-1645--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ChihweiLHBird ChihweiLHBird force-pushed the zhiwei/http-sync-etag branch from cf5af70 to 747c879 Compare June 21, 2025 08:05
@ChihweiLHBird ChihweiLHBird force-pushed the zhiwei/http-sync-etag branch from bbe70e9 to fc61a8c Compare July 7, 2025 08:10
@ChihweiLHBird ChihweiLHBird marked this pull request as ready for review July 7, 2025 08:10
@ChihweiLHBird ChihweiLHBird requested review from a team as code owners July 7, 2025 08:10
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 7, 2025
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this is a really great addition. We should also update the readme, to inform people about this behavior, as this might not be as obvious at the beginning

@beeme1mr beeme1mr requested a review from toddbaert July 9, 2025 19:14
@ChihweiLHBird
Copy link
Contributor Author

@aepfli Thank you for the suggestion! May I know which README should be changed? The one in the root directory of the repository doesn't seem to be describing sync behaviors?

@beeme1mr
Copy link
Member

@ChihweiLHBird, it may be worth mentioning the eTag behavior here. Thanks!

@beeme1mr
Copy link
Member

I'll merge this now since it should be transparent to end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support E-Tag for HTTP sync
3 participants