Conversation
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation around flag evaluation, specifically focusing on the concept of graceful defaulting. It clarifies how flagd handles cases where a Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request does a good job of updating the documentation to reflect the new 'graceful defaulting' feature and the upgrade to the v2 evaluation API. The explanations are clear and the examples are helpful.
I've left a few specific comments for minor improvements. Additionally, I noticed that the Evaluate All Flags section in docs/reference/cheat-sheet.md (lines 335-343) still contains a grpcurl example using flagd.evaluation.v1.Service/ResolveAll. Since other parts of the documentation are being updated to v2 and ResolveAll has been removed from the v2 evaluation service, this example is now inconsistent and potentially misleading. It would be great to address this to ensure all documentation is aligned with the v2 API.
Note: Security Review has been skipped due to the limited scope of the PR.
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
bc0d813 to
a2964af
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|



Add docs about graceful defaulting.