Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4627] Fix acting_subject_claim KeyError in eHerkenning via OIDC #4630

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Sep 2, 2024

Closes #4627

Changes

  • Added regression test
  • Make acting_subject_claim optional since we do not know if it will exist in the broker's response

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Sep 2, 2024
@vaszig vaszig marked this pull request as draft September 2, 2024 14:06
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.68%. Comparing base (262d84e) to head (f54f7cd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4630   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         732      732           
  Lines       24649    24649           
  Branches     3229     3229           
=======================================
  Hits        23832    23832           
  Misses        564      564           
  Partials      253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig marked this pull request as ready for review September 2, 2024 14:21
@sergei-maertens sergei-maertens merged commit 2139625 into master Sep 2, 2024
38 checks passed
@sergei-maertens sergei-maertens deleted the fix/4627-eherkenning-oidc-acting-subject-claim branch September 2, 2024 14:30
@sergei-maertens
Copy link
Member

sergei-maertens commented Sep 2, 2024

Backport: 7515293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eHerkenning via OIDC crashes if there's no acting subject claim
2 participants