Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4396] Prefill variables by using ObjectsAPI #4633

Closed
wants to merge 1 commit into from
Closed

[#4396] Prefill variables by using ObjectsAPI #4633

wants to merge 1 commit into from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Sep 4, 2024 •
edited
Loading

Closes #4396 partially,
Needs #4619, #4620

Changes

  • Added basic variables prefill functionality
  • Modified prefill plugin to comply ObjectsAPI requirements

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled

  • Release management

    • I have labelled the PR as "needs-backport" accordingly

  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft September 4, 2024 14:52
@vaszig vaszig changed the title [#4396] Started with implementing variables prefill by using ObjectsAPI [#4396] Prefill variables by using ObjectsAPI Sep 4, 2024
@vaszig vaszig linked an issue Sep 13, 2024 that may be closed by this pull request
Create a prefill plugin to prefill with values from an external reference (initially only for Objects API) #4396
Closed
@vaszig vaszig force-pushed the task/4396-objectsapi-prefill-implement-plugin branch 2 times, most recently from 6cd9cdb to a7c3df4 Compare September 23, 2024 06:43
@vaszig vaszig force-pushed the task/4396-objectsapi-prefill-functionality branch from 8acb691 to afac677 Compare September 23, 2024 11:42
@vaszig vaszig force-pushed the task/4396-objectsapi-prefill-functionality branch from afac677 to 122f18a Compare September 23, 2024 11:43
@vaszig vaszig changed the base branch from task/4396-objectsapi-prefill-implement-plugin to master September 23, 2024 11:43
@vaszig
Copy link
Contributor Author

vaszig commented Sep 23, 2024

This was initially created without having decided that ObjectsAPIGroupConfig would be restructured (moved to contrib).So, now PR 4620 is not that big and this PR can be part of it.

@vaszig vaszig closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a prefill plugin to prefill with values from an external reference (initially only for Objects API)
1 participant
@vaszig