-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4418] Add addressNl specific mappings to Objects API registration (variables tab) #4751
base: master
Are you sure you want to change the base?
[#4418] Add addressNl specific mappings to Objects API registration (variables tab) #4751
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4751 +/- ##
==========================================
+ Coverage 96.55% 96.57% +0.01%
==========================================
Files 748 748
Lines 25413 25480 +67
Branches 3358 3375 +17
==========================================
+ Hits 24538 24607 +69
+ Misses 610 608 -2
Partials 265 265 ☔ View full report in Codecov by Sentry. |
243a9ca
to
284877f
Compare
31fba07
to
0f5fff7
Compare
...s/admin/form_design/registrations/objectsapi/GenericObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...s/admin/form_design/registrations/objectsapi/GenericObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...s/admin/form_design/registrations/objectsapi/GenericObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Outdated
Show resolved
Hide resolved
0f5fff7
to
0a47362
Compare
6454967
to
041b38d
Compare
041b38d
to
44a63cd
Compare
FYI, we have to take into consideration the old forms that they already may have addressNL |
Closes #4418
Changes
This PR handles the frontend part of the task
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene