Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4418] Add addressNl specific mappings to Objects API registration (variables tab) #4751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Oct 11, 2024

Closes #4418

Changes

This PR handles the frontend part of the task

  • Added specific addressNL fields/mappings to the Objects API registration (backend-frontend)
  • Added stories

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft October 11, 2024 14:19
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.57%. Comparing base (22d641b) to head (44a63cd).
Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
...ons/contrib/objects_api/submission_registration.py 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4751      +/-   ##
==========================================
+ Coverage   96.55%   96.57%   +0.01%     
==========================================
  Files         748      748              
  Lines       25413    25480      +67     
  Branches     3358     3375      +17     
==========================================
+ Hits        24538    24607      +69     
+ Misses        610      608       -2     
  Partials      265      265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig force-pushed the task/4418-transform-mechanism-for-addressnl-in-objectsAPI branch 2 times, most recently from 243a9ca to 284877f Compare November 5, 2024 10:09
@vaszig vaszig marked this pull request as ready for review November 5, 2024 10:20
@vaszig vaszig requested a review from stevenbal November 5, 2024 10:20
@vaszig vaszig force-pushed the task/4418-transform-mechanism-for-addressnl-in-objectsAPI branch 2 times, most recently from 31fba07 to 0f5fff7 Compare November 6, 2024 14:50
@vaszig vaszig removed the request for review from stevenbal November 7, 2024 08:58
@vaszig vaszig force-pushed the task/4418-transform-mechanism-for-addressnl-in-objectsAPI branch from 0f5fff7 to 0a47362 Compare November 7, 2024 11:38
@sergei-maertens sergei-maertens marked this pull request as draft November 15, 2024 21:27
@vaszig vaszig force-pushed the task/4418-transform-mechanism-for-addressnl-in-objectsAPI branch 3 times, most recently from 6454967 to 041b38d Compare November 18, 2024 07:53
@vaszig vaszig force-pushed the task/4418-transform-mechanism-for-addressnl-in-objectsAPI branch from 041b38d to 44a63cd Compare November 18, 2024 08:22
@vaszig vaszig marked this pull request as ready for review November 18, 2024 09:31
@vaszig
Copy link
Contributor Author

vaszig commented Nov 18, 2024

FYI, we have to take into consideration the old forms that they already may have addressNL variable_mappings configured. We may need a data migration for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out a "transform" mechanism for (AddressNL) component(s) when registering them in the Objects API
3 participants