Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#4707] Resizable json widget #4786

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

robinmolen
Copy link
Contributor

Closes #4707

Changes

  • Adds the option to resize the json widget manually, via a new isResizable property
  • Made the Action Variable json widget resizable

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen linked an issue Oct 24, 2024 that may be closed by this pull request
@robinmolen robinmolen force-pushed the feature/4707-allow-resize-of-json-widget branch from db0769b to 2a2855f Compare October 24, 2024 07:56
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (7a6e0d3) to head (2d3356a).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4786   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         748      748           
  Lines       25413    25413           
  Branches     3358     3358           
=======================================
  Hits        24538    24538           
  Misses        610      610           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinmolen robinmolen marked this pull request as ready for review October 24, 2024 08:50
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it - what I see is JSON widgets now that span full width and take up way more screen size, and I can't make those smaller. The only one I found that I can make smaller is the "set a form variable action" one, and that only seems to be horizontal, but I can't make it taller?

I'm also always seeing the error message now for invalid JSON logic, while the JSON logic is valid.

That's based on testing with the deployed storybook: https://63daeae83d3113a085ae6f2e-yatxduofdx.chromatic.com/?path=/story/form-design-formlogic--full-functionality

@robinmolen robinmolen force-pushed the feature/4707-allow-resize-of-json-widget branch 2 times, most recently from 366d693 to 7faae88 Compare November 7, 2024 13:09
@robinmolen
Copy link
Contributor Author

robinmolen commented Nov 7, 2024

I've made a couple of changes..

All Json widget's are now resizable, starting from the default width. At first I only made the "set a form variable action" json widget resizable, because the ticket was regarding that situation. But there isn't a real reason why only that json widget should be resizable, so the functionality is now available for all json widgets.

The json widget is now resizable both horizontal and vertical, and the error message issue has been resolved

@robinmolen robinmolen force-pushed the feature/4707-allow-resize-of-json-widget branch from d27f458 to d08ecef Compare November 8, 2024 15:05
@robinmolen robinmolen force-pushed the feature/4707-allow-resize-of-json-widget branch from d08ecef to 2d3356a Compare November 8, 2024 15:06
@sergei-maertens sergei-maertens merged commit 19b45bd into master Nov 8, 2024
33 of 34 checks passed
@sergei-maertens sergei-maertens deleted the feature/4707-allow-resize-of-json-widget branch November 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow resizing of .json-widget in from designer
2 participants