-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#4707] Resizable json widget #4786
✨ [#4707] Resizable json widget #4786
Conversation
db0769b
to
2a2855f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4786 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 748 748
Lines 25413 25413
Branches 3358 3358
=======================================
Hits 24538 24538
Misses 610 610
Partials 265 265 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it - what I see is JSON widgets now that span full width and take up way more screen size, and I can't make those smaller. The only one I found that I can make smaller is the "set a form variable action" one, and that only seems to be horizontal, but I can't make it taller?
I'm also always seeing the error message now for invalid JSON logic, while the JSON logic is valid.
That's based on testing with the deployed storybook: https://63daeae83d3113a085ae6f2e-yatxduofdx.chromatic.com/?path=/story/form-design-formlogic--full-functionality
366d693
to
7faae88
Compare
I've made a couple of changes.. All Json widget's are now resizable, starting from the default width. At first I only made the "set a form variable action" json widget resizable, because the ticket was regarding that situation. But there isn't a real reason why only that json widget should be resizable, so the functionality is now available for all json widgets. The json widget is now resizable both horizontal and vertical, and the error message issue has been resolved |
d27f458
to
d08ecef
Compare
d08ecef
to
2d3356a
Compare
Closes #4707
Changes
isResizable
propertyChecklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene