-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor registration & payment plugin options UX - last bits #4806
Merged
sergei-maertens
merged 10 commits into
master
from
feature/refactor-remaining-registration-backends
Nov 8, 2024
Merged
Refactor registration & payment plugin options UX - last bits #4806
sergei-maertens
merged 10 commits into
master
from
feature/refactor-remaining-registration-backends
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4806 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 748 748
Lines 25413 25413
Branches 3358 3358
=======================================
Hits 24538 24538
Misses 610 610
Partials 265 265 ☔ View full report in Codecov by Sentry. |
9 tasks
robinmolen
reviewed
Nov 6, 2024
src/openforms/js/components/admin/form_design/registrations/shared/OptionsConfiguration.js
Show resolved
Hide resolved
robinmolen
reviewed
Nov 6, 2024
src/openforms/js/components/admin/form_design/registrations/demo/DemoOptionsForm.js
Outdated
Show resolved
Hide resolved
robinmolen
reviewed
Nov 6, 2024
src/openforms/js/components/admin/form_design/registrations/ms_graph/MSGraphOptionsForm.js
Outdated
Show resolved
Hide resolved
robinmolen
reviewed
Nov 6, 2024
src/openforms/js/components/admin/form_design/RegistrationFields.stories.js
Outdated
Show resolved
Hide resolved
robinmolen
reviewed
Nov 6, 2024
src/openforms/js/components/admin/form_design/registrations/ms_graph/MSGraphOptionsForm.js
Outdated
Show resolved
Hide resolved
robinmolen
reviewed
Nov 6, 2024
src/openforms/js/components/admin/form_design/payments/OptionsConfiguration.js
Outdated
Show resolved
Hide resolved
Instead of inline configuration options, expose them via a config modal instead, to be consistent with other, real, registration backends. The goal is to be able to drop RJSF eventually.
Another step towards dropping RJSF.
We used React JsonSchema Form to render a minimal form layout given the serializer definition from the backend. This is now no longer supported - you must explicitly define a configuration form (we recommend using Formik for this) to use/render for a better UX and more consistent UI appearance.
Similar to the registration backends, payment provider configuration forms must now be defined explicitly.
We only have the Camunda options form making use of the wrapper left as something to clean up, so we cannot drop the dependency entirely yet, but almost there!
They're not limited to usage in registration backends, but also useful for the payment plugin configuration, and, at some point, probably also for prefill.
Replaced the duplicated code with a dedicated 'generic' component for both payment/registration plugin configuration option forms.
sergei-maertens
force-pushed
the
feature/refactor-remaining-registration-backends
branch
from
November 8, 2024 17:21
79c897b
to
f20a7f9
Compare
sergei-maertens
deleted the
feature/refactor-remaining-registration-backends
branch
November 8, 2024 17:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket, this is my fun :)
Changes
One more PR will probably follow at some point to get the Camunda options form working without RJSF, and then the dependency can be dropped.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene