Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#4788] ConfigurationStep for Objects API registration config #4822

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Nov 12, 2024

Closes #4788
Closes #4787

TODO:

  • add identifier field to ObjectsAPIGroupConfig and use that in step
  • remove is_configured and validate_result
  • update zgw_consumers config file

Depends on:

Changes

  • ConfigurationStep for Objects API registration config

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@stevenbal stevenbal marked this pull request as draft November 12, 2024 14:37
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.56%. Comparing base (b5daa22) to head (a4fde34).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/openforms/config/setup_configuration/steps.py 97.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4822   +/-   ##
=======================================
  Coverage   96.55%   96.56%           
=======================================
  Files         748      750    +2     
  Lines       25417    25483   +66     
  Branches     3361     3372   +11     
=======================================
+ Hits        24542    24607   +65     
  Misses        610      610           
- Partials      265      266    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal changed the title 📌 [#4788] Pin zgw-consumers to branch ✨ [#4788] ConfigurationStep for Objects API registration config Nov 12, 2024
@stevenbal stevenbal force-pushed the feature/setup-configuration branch 5 times, most recently from 205b1fc to 1fe35d5 Compare November 15, 2024 14:57
this is needed to load the Services required to setup configuration such as ObjectsAPIGroupConfig, etc.
add a web-init container and the required scripts for setup_configuration. Example data has been added to docker/setup_configuration
this step relies on the previously added ServiceConfigurationStep and can be used to set up the necessary configuration for the Objects API registration backend
to avoid having to bring up the Open Zaak and Objects/Objecttypes docker compose stacks for the CI tests to simulate upgrading Open Forms
@@ -0,0 +1,32 @@
from django_setup_configuration.models import ConfigurationModel, DjangoModelRef
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't entirely sure on what directory to place these files in, should they be in src/openforms/config/... or in src/openforms/contrib/...?

Copy link
Member

@sergei-maertens sergei-maertens Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm, will have to have a think, I think it'll partly be both? e.g. 3rd party library stuff like zgw consumers in config, and openforms constructs (like objectsapigroup) in contrib close to where the models are defined.

This of course assumes such degree of modularity in django-setup-configuration

@stevenbal
Copy link
Contributor Author

stevenbal commented Nov 15, 2024

@sergei-maertens this PR of course depends on the changes in django-setup-configuration and zgw-consumers, but I figured it would be good if you could take a look at the implementation before I start working on #4789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants