-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#4788] ConfigurationStep for Objects API registration config #4822
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4822 +/- ##
=======================================
Coverage 96.55% 96.56%
=======================================
Files 748 750 +2
Lines 25417 25483 +66
Branches 3361 3372 +11
=======================================
+ Hits 24542 24607 +65
Misses 610 610
- Partials 265 266 +1 ☔ View full report in Codecov by Sentry. |
dfdfd01
to
c52c208
Compare
205b1fc
to
1fe35d5
Compare
this is needed to load the Services required to setup configuration such as ObjectsAPIGroupConfig, etc.
add a web-init container and the required scripts for setup_configuration. Example data has been added to docker/setup_configuration
this step relies on the previously added ServiceConfigurationStep and can be used to set up the necessary configuration for the Objects API registration backend
to avoid having to bring up the Open Zaak and Objects/Objecttypes docker compose stacks for the CI tests to simulate upgrading Open Forms
1fe35d5
to
a4fde34
Compare
@@ -0,0 +1,32 @@ | |||
from django_setup_configuration.models import ConfigurationModel, DjangoModelRef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't entirely sure on what directory to place these files in, should they be in src/openforms/config/...
or in src/openforms/contrib/...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm, will have to have a think, I think it'll partly be both? e.g. 3rd party library stuff like zgw consumers in config
, and openforms constructs (like objectsapigroup) in contrib
close to where the models are defined.
This of course assumes such degree of modularity in django-setup-configuration
@sergei-maertens this PR of course depends on the changes in django-setup-configuration and zgw-consumers, but I figured it would be good if you could take a look at the implementation before I start working on #4789 |
Closes #4788
Closes #4787
TODO:
identifier
field to ObjectsAPIGroupConfig and use that in stepDepends on:
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene