Skip to content

issue 594: Rework unit-test for ApiUtilsSuite #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2024
Merged

issue 594: Rework unit-test for ApiUtilsSuite #730

merged 2 commits into from
Nov 4, 2024

Conversation

@omordyk
Copy link
Contributor

@omordyk omordyk commented Nov 4, 2024 •
edited
Loading

issue 594: Rework unit-test for ApiUtilsSuite
Description: #594

Changes that were implemented:

  • Split ApiUtilsSuite in two tests: TestApiUtilsTime and TestNodeAgbotTokenValidation.
  • Extend number of tests for TestApiUtilsTime and TestNodeAgbotTokenValidation.
  • Add validation for invalid time format:
  test("ApiTime fixFormatting handles invalid format") {
    val invalidTime = "invalid-time-format"
    info(ApiTime.fixFormatting(invalidTime) + " , " + "Invalid format")
    assert(ApiTime.fixFormatting(invalidTime) == "Invalid format")
  }

@omordyk omordyk force-pushed the issue_594 branch 2 times, most recently from cd53086 to 2fd066a Compare November 4, 2024 12:03
@omordyk omordyk marked this pull request as ready for review November 4, 2024 12:13
@omordyk omordyk self-assigned this Nov 4, 2024
@naphelps
Copy link
Member

naphelps commented Nov 4, 2024

@omordyk Just need to update this branch with master before I can merge.

@omordyk
issue 594: Rework unit-test for ApiUtilsSuite
9366245 
- Split ApiUtilsSuite in two tests: TestApiUtilsTime and TestNodeAgbotTokenValidation.
- Extend number of tests for TestApiUtilsTime and TestNodeAgbotTokenValidation.
- Add validation for invalid time format.

Signed-off-by: Oleksandr Mordyk <[email protected]>
@omordyk
issue 594: Update exchange-api version to 2.125.3
9887b2d 
Signed-off-by: Oleksandr Mordyk <[email protected]>
@omordyk
Copy link
Contributor Author

omordyk commented Nov 4, 2024

@naphelps rebased

@naphelps naphelps merged commit 33cc8ed into master Nov 4, 2024
2 checks passed
@naphelps naphelps deleted the issue_594 branch November 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naphelps naphelps naphelps approved these changes

@geforcelive2 geforcelive2 Awaiting requested review from geforcelive2

Assignees

@omordyk omordyk

Labels

unit-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omordyk @naphelps