Skip to content

Replace os.path with pathlib.Path in diffcrash #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

saudzahirr
Copy link
Contributor

This PR refactors the code in diffcrash to replace all instances of os.path with pathlib.Path. The use of os.path is considered less modern compared to pathlib.Path, which was introduced in Python 3.4. pathlib is now the preferred way to handle filesystem paths in modern Python code.

@saudzahirr
Copy link
Contributor Author

saudzahirr commented Apr 11, 2025

@codie3611 Please review this, if you are available.

Copy link
Contributor

@codie3611 codie3611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I also prefer the Path. It is so much better.

@saudzahirr
Copy link
Contributor Author

@codie3611 Please merge it as I don't have merge rights.

@codie3611 codie3611 merged commit dc9f2d1 into open-lasso-python:develop Apr 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants