Skip to content

Using ruff for linting #03 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saudzahirr
Copy link
Contributor

Update ruff lint select rules. This pull request includes follow-up modifications and refinements related to the integration of Ruff, a linter for Python. Updated rules in pyproject.toml:

  • W – pycodestyle warnings (e.g., extra spaces, indentation issues)
  • F – Pyflakes errors (e.g., unused imports, undefined variables)
  • TID – flake8-tidy-imports (checks for banned or misplaced imports)

@saudzahirr
Copy link
Contributor Author

@codie3611 Please review this, if you are available.

@codie3611 codie3611 requested a review from Copilot May 23, 2025 10:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the Ruff linter configuration and updates several import statements from relative to absolute paths to improve module clarity and consistency.

  • Updated Ruff linting rules in pyproject.toml
  • Changed relative import paths to absolute paths across multiple modules
  • Improved import consistency in various dimensions of the codebase

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lasso/dyna/d3plot_header.py Updated relative imports to absolute imports for binary buffering and logging.
src/lasso/dyna/d3plot.py Updated all relative imports to absolute imports to enhance namespace clarity.
src/lasso/dimred/svd/subsampling_methods.py Converted relative import statements to absolute paths.
src/lasso/dimred/hashing.py Updated relative import of a math utility to its new absolute module path.
src/lasso/dimred/dimred_run.py Changed relative imports to absolute ones in the dimensionality reduction runner.
src/lasso/diffcrash/run.py Updated logging import from relative to absolute for improved clarity.
src/lasso/diffcrash/diffcrash_run.py Switched commented-out relative import to an absolute import format.
pyproject.toml Uncommented specific Ruff lint rules to enforce pycodestyle warnings, Pyflakes errors, and tidy imports.

@codie3611 codie3611 merged commit 8157b8a into open-lasso-python:develop May 23, 2025
5 checks passed
@saudzahirr saudzahirr deleted the refactor/ruff_followup_03 branch May 23, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants