Skip to content

Refactor team action button state handling #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor team action button state handling #8269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
401fc78
Refactor team action button state management
Sakshamnayyar Oct 7, 2025
98d673d
Fix Realm thread access in team join flow
Sakshamnayyar Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 16 additions & 50 deletions app/src/main/java/org/ole/planet/myplanet/ui/team/AdapterTeamList.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package org.ole.planet.myplanet.ui.team

import android.content.Context
import android.content.DialogInterface
import android.graphics.PorterDuff
import android.graphics.Typeface
import android.os.Bundle
import android.view.LayoutInflater
Expand Down Expand Up @@ -140,56 +139,22 @@ class AdapterTeamList(
team: RealmMyTeam,
user: RealmUserModel?,
) {
if (isMyTeam) {
name.setTypeface(null, Typeface.BOLD)
} else {
name.setTypeface(null, Typeface.NORMAL)
val viewContext = root.context
name.setTypeface(null, if (isMyTeam) Typeface.BOLD else Typeface.NORMAL)

val state = when {
user?.isGuest() == true -> TeamActionButtonState.Hidden
isTeamLeader -> TeamActionButtonState.Edit("${viewContext.getString(R.string.edit)} ${team.name}")
isMyTeam && !isTeamLeader -> TeamActionButtonState.Leave("${viewContext.getString(R.string.leave)} ${team.name}")
!isMyTeam && hasPendingRequest -> TeamActionButtonState.Requested(
"${viewContext.getString(R.string.requested)} ${team.name}",
"#9fa0a4".toColorInt(),
)
!isMyTeam -> TeamActionButtonState.Join("${viewContext.getString(R.string.request_to_join)} ${team.name}")
else -> TeamActionButtonState.Hidden
}
when {
user?.isGuest() == true -> joinLeave.visibility = View.GONE

isTeamLeader -> {
joinLeave.apply {
isEnabled = true
contentDescription = "${context.getString(R.string.edit)} ${team.name}"
visibility = View.VISIBLE
setImageResource(R.drawable.ic_edit)
clearColorFilter()
}
}

isMyTeam && !isTeamLeader -> {
joinLeave.apply {
isEnabled = true
contentDescription = "${context.getString(R.string.leave)} ${team.name}"
visibility = View.VISIBLE
setImageResource(R.drawable.logout)
clearColorFilter()
}
}

!isMyTeam && hasPendingRequest -> {
joinLeave.apply {
isEnabled = false
contentDescription = "${context.getString(R.string.requested)} ${team.name}"
visibility = View.VISIBLE
setImageResource(R.drawable.baseline_hourglass_top_24)
setColorFilter("#9fa0a4".toColorInt(), PorterDuff.Mode.SRC_IN)
}
}

!isMyTeam -> {
joinLeave.apply {
isEnabled = true
contentDescription = "${context.getString(R.string.request_to_join)} ${team.name}"
visibility = View.VISIBLE
setImageResource(R.drawable.ic_join_request)
clearColorFilter()
}
}

else -> joinLeave.visibility = View.GONE
}
applyActionButtonState(state)
}

private fun handleJoinLeaveClick(team: RealmMyTeam, user: RealmUserModel?) {
Expand Down Expand Up @@ -304,8 +269,9 @@ class AdapterTeamList(

private fun requestToJoin(team: RealmMyTeam, user: RealmUserModel?) {
val teamId = team._id ?: return
val teamType = team.teamType
scope.launch(Dispatchers.IO) {
teamRepository.requestToJoin(teamId, user, team.teamType)
teamRepository.requestToJoin(teamId, user, teamType)
val cacheKey = "${teamId}_${user?.id}"
teamStatusCache.remove(cacheKey)
}
Expand Down
56 changes: 56 additions & 0 deletions app/src/main/java/org/ole/planet/myplanet/ui/team/TeamActionButtonState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
package org.ole.planet.myplanet.ui.team

import android.graphics.PorterDuff
import android.view.View
import org.ole.planet.myplanet.R
import org.ole.planet.myplanet.databinding.ItemTeamListBinding

sealed class TeamActionButtonState(
val iconRes: Int?,
val isEnabled: Boolean,
val contentDescription: String?,
val visibility: Int = View.VISIBLE,
val colorFilter: Int? = null,
val colorFilterMode: PorterDuff.Mode = PorterDuff.Mode.SRC_IN,
) {
object Hidden : TeamActionButtonState(iconRes = null, isEnabled = false, contentDescription = null, visibility = View.GONE)

class Join(contentDescription: String) : TeamActionButtonState(
iconRes = R.drawable.ic_join_request,
isEnabled = true,
contentDescription = contentDescription,
)

class Requested(contentDescription: String, colorFilter: Int) : TeamActionButtonState(
iconRes = R.drawable.baseline_hourglass_top_24,
isEnabled = false,
contentDescription = contentDescription,
colorFilter = colorFilter,
)

class Leave(contentDescription: String) : TeamActionButtonState(
iconRes = R.drawable.logout,
isEnabled = true,
contentDescription = contentDescription,
)

class Edit(contentDescription: String) : TeamActionButtonState(
iconRes = R.drawable.ic_edit,
isEnabled = true,
contentDescription = contentDescription,
)
}

fun ItemTeamListBinding.applyActionButtonState(state: TeamActionButtonState) {
joinLeave.visibility = state.visibility
joinLeave.isEnabled = state.isEnabled
joinLeave.contentDescription = state.contentDescription

state.iconRes?.let { joinLeave.setImageResource(it) }

if (state.colorFilter != null) {
joinLeave.setColorFilter(state.colorFilter, state.colorFilterMode)
} else {
joinLeave.clearColorFilter()
}
}