fix(sync): Refactor exam upload to prevent OutOfMemoryError #8997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `uploadExamResult` function was loading all exam submissions into memory before serialization, causing an `OutOfMemoryError` on devices with a large number of submissions. This change refactors the function to use a batching strategy: 1. It first queries only the IDs of the submissions that need to be uploaded. 2. It then processes these IDs in batches. 3. For each batch, it fetches the full submission objects from Realm, serializes them, and uploads them. This approach ensures that only a small, manageable number of submissions are held in memory at any given time, resolving the crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
uploadExamResultfunction was loading all exam submissions into memory before serialization, causing anOutOfMemoryErroron devices with a large number of submissions.This change refactors the function to use a batching strategy:
This approach ensures that only a small, manageable number of submissions are held in memory at any given time, resolving the crash.
https://jules.google.com/session/13589167571013959552