fix(anr): Resolve ANR in AutoSyncWorker by making uploads asynchronous #9001
Conversation
Refactored `uploadExamResult`, `uploadFeedback`, `uploadAchievement`, and `uploadResourceActivities` in `UploadManager` to be `suspend` functions. This moves the blocking database, serialization, and network operations to a background thread, resolving the ANR. Updated the call sites in `AutoSyncWorker` to launch these functions within a coroutine on the `applicationScope`. Also restored error handling to `uploadExamResult` that was removed in a previous refactoring.
Refactored `uploadExamResult`, `uploadFeedback`, `uploadAchievement`, and `uploadResourceActivities` in `UploadManager` to be `suspend` functions. This moves the blocking database, serialization, and network operations to a background thread, resolving the ANR. Updated the call sites in `AutoSyncWorker`, `UserInformationFragment`, `ServerReachabilityWorker`, and `ProcessUserDataActivity` to launch these functions within a coroutine on an appropriate scope. This resolves the compilation errors introduced by the refactoring. Also restored error handling to `uploadExamResult` that was removed in a previous refactoring.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val asyncOperationsCounter = AtomicInteger(0) | ||
| val totalAsyncOperations = 6 |
There was a problem hiding this comment.
After uploadExamResult() and uploadFeedback() were converted to suspending functions and invoked before the counter, only five callbacks now call checkAllOperationsComplete(), but totalAsyncOperations remains 6. This means the atomic counter never reaches the expected value and the progress dialog is never dismissed after the remaining uploads finish.
Useful? React with 👍 / 👎.
|
@Okuro3499 my branch got created on saturday |
Refactored
uploadExamResult,uploadFeedback,uploadAchievement, anduploadResourceActivitiesinUploadManagerto besuspendfunctions. This moves the blocking database, serialization, and network operations to a background thread, resolving the ANR.Updated the call sites in
AutoSyncWorkerto launch these functions within a coroutine on theapplicationScope.Also restored error handling to
uploadExamResultthat was removed in a previous refactoring.https://jules.google.com/session/15369501537486835428