Skip to content

Fix: Move DB operations to IO dispatcher in FeedbackDetailViewModel #9015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Move DB operations to IO dispatcher in FeedbackDetailViewModel #9015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c93bdf5
Fix: Move DB operations to IO dispatcher in FeedbackDetailViewModel
google-labs-jules[bot] Nov 10, 2025
030799a
Fix: Move DB operations to IO dispatcher in FeedbackDetailViewModel
google-labs-jules[bot] Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/src/main/java/org/ole/planet/myplanet/ui/feedback/FeedbackDetailViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import androidx.lifecycle.viewModelScope
import com.google.gson.JsonObject
import dagger.hilt.android.lifecycle.HiltViewModel
import javax.inject.Inject
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.SharedFlow
Expand All @@ -27,21 +28,21 @@ class FeedbackDetailViewModel @Inject constructor(
val events: SharedFlow<FeedbackDetailEvent> = _events.asSharedFlow()

fun loadFeedback(id: String?) {
viewModelScope.launch {
viewModelScope.launch(Dispatchers.IO) {
_feedback.value = feedbackRepository.getFeedbackById(id)
}
}

fun closeFeedback(id: String?) {
viewModelScope.launch {
viewModelScope.launch(Dispatchers.IO) {
feedbackRepository.closeFeedback(id)
_feedback.value = feedbackRepository.getFeedbackById(id)
_events.emit(FeedbackDetailEvent.CloseFeedbackSuccess)
}
}

fun addReply(id: String?, obj: JsonObject) {
viewModelScope.launch {
viewModelScope.launch(Dispatchers.IO) {
feedbackRepository.addReply(id, obj)
_feedback.value = feedbackRepository.getFeedbackById(id)
}
Expand Down