Skip to content

Fix Realm Listener Leak in AchievementFragment #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Realm Listener Leak in AchievementFragment #9019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/src/main/java/org/ole/planet/myplanet/ui/userprofile/AchievementFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class AchievementFragment : BaseContainerFragment() {
private var _binding: FragmentAchievementBinding? = null
private val binding get() = _binding!!
private lateinit var aRealm: Realm
private lateinit var realmChangeListener: io.realm.RealmChangeListener<Realm>
var user: RealmUserModel? = null
var listener: OnHomeItemClickListener? = null
private var achievement: RealmAchievement? = null
Expand Down Expand Up @@ -82,11 +83,14 @@ class AchievementFragment : BaseContainerFragment() {
}

override fun onDestroyView() {
super.onDestroyView()
if (::realtimeSyncListener.isInitialized) {
syncCoordinator.removeListener(realtimeSyncListener)
}
if (::realmChangeListener.isInitialized) {
aRealm.removeChangeListener(realmChangeListener)
}
_binding = null
super.onDestroyView()
}

private fun startAchievementSync() {
Expand Down Expand Up @@ -193,11 +197,12 @@ class AchievementFragment : BaseContainerFragment() {

achievement?.let {
updateAchievementUI()
aRealm.addChangeListener {
realmChangeListener = io.realm.RealmChangeListener {
if (isAdded) {
populateAchievements()
}
}
aRealm.addChangeListener(realmChangeListener)
}
}

Expand Down Expand Up @@ -303,7 +308,6 @@ class AchievementFragment : BaseContainerFragment() {
customProgressDialog?.dismiss()
customProgressDialog = null
if (this::aRealm.isInitialized && !aRealm.isClosed) {
aRealm.removeAllChangeListeners()
aRealm.close()
}
try {
Expand Down