Refactor: Move "My Library" data loading to ViewModel #9021
Conversation
Refactored `BaseDashboardFragment` to use `DashboardViewModel` for fetching the "My Library" data. - Injected `DashboardViewModel` into `BaseDashboardFragment` using Hilt. - Moved the Realm query for library items from the fragment to a `suspend` function in the ViewModel. - The fragment now calls the ViewModel from a `lifecycleScope` coroutine to load the data asynchronously. - This change moves a database query off the main thread, improving performance and adhering to a better architectural pattern by separating UI and data concerns.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| suspend fun getUnreadNotificationsSize(userId: String?): Int { | ||
| return notificationRepository.getUnreadCount(userId) | ||
| } | ||
|
|
||
| suspend fun getMyLibraryItems(userId: String?): List<RealmMyLibrary> { | ||
| return libraryRepository.getLibraryListForUser(userId) |
There was a problem hiding this comment.
The new getMyLibraryItems delegates to LibraryRepository.getLibraryListForUser, which filters results to non‑private items that needToUpdate() and does not merge team resources. The previous fragment code called RealmMyLibrary.getMyLibraryByUserId, which returned all items the user owns or receives through team membership regardless of update status. As a result, the dashboard’s “My Library” section will now omit any up‑to‑date or team‑shared resources and show only those needing updates, changing the visible data set rather than just moving the query off the main thread.
Useful? React with 👍 / 👎.
Refactored
BaseDashboardFragmentto useDashboardViewModelfor fetching the "My Library" data.DashboardViewModelintoBaseDashboardFragmentusing Hilt.suspendfunction in the ViewModel.lifecycleScopecoroutine to load the data asynchronously.https://jules.google.com/session/3990081894014682692