feat(dashboard): Optimize DashboardActivity startup #9022
Conversation
- Moved non-critical initializations from onCreate to onStart. - Introduced postponeEnterTransition() and reportFullyDrawn() for faster UI rendering. - Batched heavy tasks into a background coroutine to prevent blocking the main thread.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| override fun onStart() { | ||
| super.onStart() | ||
| lifecycleScope.launch(Dispatchers.IO) { | ||
| setupHeavyTasks() | ||
| } | ||
| } | ||
|
|
||
| private fun setupHeavyTasks() { | ||
| setupNavigation() | ||
| setupRealmListeners() | ||
| challengeHelper = ChallengeHelper(this, mRealm, user, settings, editor, dashboardViewModel) | ||
| challengeHelper.evaluateChallengeDialog() |
There was a problem hiding this comment.
The new onStart coroutine uses Dispatchers.IO to invoke setupHeavyTasks(), but that method still calls setupRealmListeners() and creates ChallengeHelper. Both rely on the activity’s mRealm (instantiated on the main thread in SyncActivity.onCreate) and immediately interact with fragments when evaluateChallengeDialog() shows dialogs. Realm objects are thread-confined and fragment operations must run on the main thread, so executing them on the IO dispatcher will crash with IllegalStateException or CalledFromWrongThreadException as soon as the activity starts. These calls need to stay on the main thread or use a background Realm instance and post UI work back to the main dispatcher.
Useful? React with 👍 / 👎.
https://jules.google.com/session/5972562439060210828