-
Notifications
You must be signed in to change notification settings - Fork 43
chatapi: smoother port number (fixes #8760) #8761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Maybe it's just me, but my Chatapi folder had a .env file, where I had to edit the SERVE_PORT variable or else it still fell back to port 5000. Running normally on 5050 now though. |
Thanks! Added this step to the testing instructions |
|
After discussions, moved from Tested on
Also updated the wiki development instructions to reflect this change: open-learning-exchange/open-learning-exchange.github.io#3626 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paulbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! As a note the gists will need to be updated for production as well as development in the 10 steps to use 5400.
dogi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mutugiii the code is fine but we already have to many production systems
with network config outside

Fixes #8760
5400, switching from5000To test:
First stop the chatapi docker container using
Create a .env file in the chatapi with the following env:
Then (if you don't have node 18 installed run
nvm install 18 or fnm install 18):Visit localhost:5400/checkproviders to confirm