dashboard: smoother events creation (fixes #9109) #9134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelbaa
changed the title
jessewashburn
requested changes
Sep 24, 2025
Member
jessewashburn
left a comment
jessewashburn
left a comment
There was a problem hiding this comment.
I like the idea, but currently I'm seeing some weird margins.
On Firefox:
On Chrome the issue is more subtle, but you can see the top of the 0 and the 2 are slightly cut off.
Member
Author
good catch. |
dogi
changed the title
Member
|
Hi @emmanuelbaa, |
This change fixes a visual bug in the time picker input fields where the text was being cut off due to incorrect margins and padding. The fix adds a new CSS class to the time picker fields and applies a padding to the input element to ensure the text is displayed correctly in all browsers.
This change fixes a visual bug in the time picker input fields where the text was being cut off due to incorrect margins and padding. The fix adds a new CSS class to the time picker fields and applies a height to the input element to ensure the text is displayed correctly in all browsers.
…/github.com/open-learning-exchange/planet into 9109-addevent-addaSupoortingTimePicker-Baah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9109
added a time picker to the add event dialogue.