-
Notifications
You must be signed in to change notification settings - Fork 43
community: changed services to information (fixes #9267) #9273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Renames the "Services" tab to "Information" and moves it to be the second tab in the community view. This is in response to user feedback to make the tab more descriptive and prominent.
Saby-Bishops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The empty <ng-container *ngIf="!planetCode"> currently doesn’t render any content even when !planetCode is true. Unless we plan to display a message or component for that state, I think it can be safely removed.
.gitignore
Outdated
| environment.dev.ts | ||
|
|
||
| # Gemini CLI configuration | ||
| gemini-extension.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Careful, sometimes Jules and Codex can create unnecessary file/line changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the gemini cli doesn't need the gemini-extension.json to run
jessewashburn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
Removed unnecessary ng-container for planetCode check.
fixes #9267
feat: Rename and reorder community tabs
Renamed the "Services" tab to "Information" and moved it to be the second tab in the community view. This is to make the tab more descriptive and prominent.