src/app/shared/forms/planet-rating.component.ts (fixes #9297)

[Saby-Bishops]

fixes #9297

Summary

• migrate planet-rating forms to typed FormGroup models
• update rate/comment controls and form interactions to align with typed values

Testing

• npm run lint

---

https://chatgpt.com/codex/tasks/task_e_690508941d14832dafef79d397c28765

[chatgpt-codex-connector]

💡 Codex Review

planet/src/app/shared/forms/planet-rating.component.ts

Lines 170 to 175 in 827295d

	openDialog() {
	this.popupForm.patchValue(this.rateForm.value);
	this.isPopupOpen = true;
	this.dialogsForm
	.confirm($localize`Rating`, popupFormFields, this.popupForm)
	.pipe(debug('Dialog confirm'))

Passing typed FormGroup breaks rating dialog

The newly typed popupForm is created with FormBuilder and passed to dialogsForm.confirm(...). DialogsFormService.confirm only recognises UntypedFormGroup instances as existing forms; a typed FormGroup fails that check and is rewrapped via UntypedFormBuilder.group(formGroup), which treats the FormGroup object as configuration and produces controls named controls, value, etc rather than rate/comment. When the modal template later looks up rate or comment, the dialog will render without those controls or throw “Cannot find control 'rate'”, preventing users from submitting a comment. The dialog service or call site needs to accept typed groups without recreating them.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".