Skip to content

Remove undefined APK version writes and unused variable in upgrade script#9632

Closed
Saby-Bishops wants to merge 1 commit intomasterfrom
codex/remove-localapkname-and-undefined-echo
Closed

Remove undefined APK version writes and unused variable in upgrade script#9632
Saby-Bishops wants to merge 1 commit intomasterfrom
codex/remove-localapkname-and-undefined-echo

Conversation

@Saby-Bishops
Copy link
Member

Motivation

  • Prevent the script from writing blank or incorrect APK version metadata by removing writes that referenced the undefined $tag variable and removing an unused local APK name.

Description

  • Deleted the localApkName variable and removed the two echo $tag > /usr/share/nginx/html/fs/apkversion lines from docker/planet/nginx/upgrade_planetapk_fromnation.sh, leaving the APK download and SHA256 verification flow unchanged.

Testing

  • Ran bash -n docker/planet/nginx/upgrade_planetapk_fromnation.sh which completed without syntax errors.

Codex Task

@Saby-Bishops Saby-Bishops marked this pull request as ready for review March 2, 2026 21:40
@Mutugiii Mutugiii added the close? label Mar 5, 2026
@Mutugiii
Copy link
Member

Mutugiii commented Mar 5, 2026

myPlanet apk version is used to distribute myPlanet with planet

image

@Mutugiii Mutugiii closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants