Fix(UI): Add conditional rendering for ClassificationDetails GenericProvider

[siddhant1]

Summary

• Conditionally render GenericProvider in ClassificationDetails only when currentClassification is defined, preventing child components (DomainLabelV2, OwnerLabelV2) from receiving an empty {} object and accessing undefined properties
• Show a <Loader /> while classification data is being fetched
• Remove unsafe as Classification type assertion and ?? {} fallback

Test plan

• Navigate between classifications — verify Loader appears during transitions
• Verify classification details (description, tags table, domain, owner) render correctly after loading
• Simulate API error — verify ErrorPlaceHolder renders correctly
• Verify version history button and manage button still work as expected

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[gitar-bot]

💡 Quality: Loader import breaks grouping order of imports

The Loader import on line 68 is placed between the ../../Customization/ and ../../DataAssets/ import groups, breaking the established import ordering convention. All ../../common/ imports should be grouped together (lines 60-65) before the ../../Customization/ imports.

This is purely cosmetic and has no functional impact, but consistent import ordering helps with readability and reduces merge conflicts.

Suggested fix:

import Table from '../../common/Table/Table';
import Loader from '../../common/Loader/Loader';
import { GenericProvider } from '../../Customization/GenericProvider/GenericProvider';
import { DomainLabelV2 } from '../../DataAssets/DomainLabelV2/DomainLabelV2';
import { OwnerLabelV2 } from '../../DataAssets/OwnerLabelV2/OwnerLabelV2';

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

🔍 CI failure analysis for c721209: Playwright shard 4/6 failed again on retry with 3 different test failures in Entity, Domains, and Pipeline tests - all unrelated to this PR's ClassificationDetails changes.

Issue

Playwright CI shard 4/6 failed on retry (job 64997267789) with 3 test failures, all in components unrelated to the PR changes.

Root Cause

All failing tests are in Entity/Domain/Pipeline-related test files, completely separate from the ClassificationDetails component modified in this PR:

Shard 4/6 Retry (job 64997267789):

1. Test: Entity.spec.ts:2140:7 › Table › Set & update column-level custom property

   • Error: Test timeout (180000ms exceeded) + loader stuck visible (expected 0, received 1)
   • Location: entity.ts:53 - waitForAllLoadersToDisappear
   • Retry: Failed on both initial attempt and retry Create teams page similar to tags #1
   • Type: Infrastructure/timeout issue with loader not disappearing

2. Test: Domains.spec.ts:1400:3 › Domains › Verify duplicate domain creation

   • Error: Strict mode violation - getByTestId('add-domain') resolved to 2 elements instead of 1
   • Location: Domains.spec.ts:1415
   • Type: DOM element duplication issue

3. Test: Entity.spec.ts:1379:7 › Pipeline › Glossary Term Add, Update and Remove for child entities

   • Error: Element not found - add-tag button not visible
   • Location: entity.ts:1079
   • Type: Missing UI element

Details

Why these failures are unrelated to this PR:

This PR only modifies:

• ClassificationDetails.tsx - conditional rendering for GenericProvider
• ClassificationDetails.test.tsx - unit tests for the component
• ClassificationConditionalRendering.spec.ts - E2E tests for classification page

The failing tests are for:

• Table entity custom property management
• Domains page duplicate domain creation validation
• Pipeline entity glossary term management

These are entirely different UI flows, components, and data models. The shard has failed consistently across multiple retries with different flaky tests, indicating infrastructure instability rather than PR-related issues.

Previous failures in this shard:

• Initial run (job 64981423405): Same custom property timeout
• Current retry (job 64997267789): Same custom property timeout + 2 new failures

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Clean fix that properly guards GenericProvider with conditional rendering, eliminating unsafe type assertion and empty object fallback. Good test coverage for the new loading states. Only a minor import ordering nit.

💡 Quality: Loader import breaks grouping order of imports

📄 openmetadata-ui/src/main/resources/ui/src/components/Classifications/ClassificationDetails/ClassificationDetails.tsx:68

The Loader import on line 68 is placed between the ../../Customization/ and ../../DataAssets/ import groups, breaking the established import ordering convention. All ../../common/ imports should be grouped together (lines 60-65) before the ../../Customization/ imports.

This is purely cosmetic and has no functional impact, but consistent import ordering helps with readability and reduces merge conflicts.

Suggested fix

import Table from '../../common/Table/Table';
import Loader from '../../common/Loader/Loader';
import { GenericProvider } from '../../Customization/GenericProvider/GenericProvider';
import { DomainLabelV2 } from '../../DataAssets/DomainLabelV2/DomainLabelV2';
import { OwnerLabelV2 } from '../../DataAssets/OwnerLabelV2/OwnerLabelV2';

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[github-actions]

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	65.75% (56554/86018)	45.25% (29643/65512)	47.96% (8925/18608)

[sonarqubecloud]

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud