Open
Conversation
function has a arg for device which defaults to 'cuda'
Author
|
@RunningLeon would appreciate your review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
=======================================
Coverage 48.38% 48.38%
=======================================
Files 357 357
Lines 13850 13850
Branches 2046 2046
=======================================
Hits 6702 6702
Misses 6693 6693
Partials 455 455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I ran into this issue and this patch fixed it for me as well! |
henryrobbins
added a commit
to henryrobbins/mmdeploy
that referenced
this pull request
Dec 10, 2024
Note: there is already an outstanding PR to resolve this issue: open-mmlab#2715
|
If this MR doesn't get merged here, feel free to open it against our VBTI fork at https://github.com/VBTI-development/onedl-mmdeploy- we're actively maintaining updated versions with latest PyTorch support and would welcome the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
single_level_grid_priorshas a arg to specify device, which defaults to'cuda'. this PR fixes the function to allow usingcpu.Modification
pass in the value of
mask_feat.deviceto the method instead of converting the tensor afterwards.BC-breaking (Optional)
no breaking changes
Use cases (Optional)
no new features
Checklist