Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0.x/opal/cuda: Handle stream-ordered allocations and assign primary device #12843

Merged
merged 1 commit into from
Oct 30, 2024
Merged

5.0.x/opal/cuda: Handle stream-ordered allocations and assign primary device #12843

merged 1 commit into from
Oct 30, 2024

Conversation

Akshay-Venkatesh
Copy link
Contributor

Port of #12835

@github-actions github-actions bot added this to the v5.0.6 milestone Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

fdb497d: opal/cuda: Handle stream-ordered allocations and a...

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: 5328616

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@Akshay-Venkatesh Akshay-Venkatesh force-pushed the topic/5.0.x/handle-masync-assign-ctx branch from fdb497d to c09e947 Compare October 3, 2024 21:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

c09e947: opal/cuda: Handle stream-ordered allocations and a...

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: 5328616

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

4537ce9: Merge branch 'v5.0.x' into topic/5.0.x/handle-masy...

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

c09e947: opal/cuda: Handle stream-ordered allocations and a...

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: 5328616

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@Akshay-Venkatesh Akshay-Venkatesh force-pushed the topic/5.0.x/handle-masync-assign-ctx branch from 4537ce9 to 6984154 Compare October 3, 2024 21:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

6984154: opal/cuda: Handle stream-ordered allocations and a...

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: 5328616

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@Akshay-Venkatesh
Copy link
Contributor Author

@janjust I'm guessing this issue goes way once parent branch has been merged. Is that correct?

@janjust
Copy link
Contributor

janjust commented Oct 3, 2024

correct

@janjust janjust changed the title 5.0.x/opal/cuda: Handle stream-ordered allocations and assign primary device 5.0.x/opal/cuda: Handle stream-ordered allocations and assign primary device Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

6984154: opal/cuda: Handle stream-ordered allocations and a...

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: 5328616

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@janjust
Copy link
Contributor

janjust commented Oct 4, 2024

@Akshay-Venkatesh please do another cherry-pick amend, I think after you opened this PR, and then forced push to the main PR, the hash is different now, thus the commit checker will fail.

@Akshay-Venkatesh Akshay-Venkatesh force-pushed the topic/5.0.x/handle-masync-assign-ctx branch from 6984154 to fd9cd3f Compare October 7, 2024 16:33
@Akshay-Venkatesh
Copy link
Contributor Author

@janjust Does this look like a related error https://github.com/open-mpi/ompi/actions/runs/11219955917/job/31192809106?pr=12843#step:9:26 ?

@Akshay-Venkatesh @jsquyres
opal/cuda: Handle stream-ordered allocations and assign primary devic…
54f4ba4 
…e context

Signed-off-by: Akshay Venkatesh <[email protected]>
(cherry picked from commit cafcce9)
@jsquyres jsquyres force-pushed the topic/5.0.x/handle-masync-assign-ctx branch from fd9cd3f to 54f4ba4 Compare October 28, 2024 19:07
@jsquyres
Copy link
Member

Rebased to pick up mpi4py github action fix.

@janjust janjust merged commit 5fd8028 into open-mpi:v5.0.x Oct 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janjust janjust janjust approved these changes

@bosilca bosilca bosilca approved these changes

Assignees
No one assigned
Labels
Target: v5.0.x
Projects
None yet
Milestone
v5.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Akshay-Venkatesh @janjust @jsquyres @bosilca