Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.x: NEWS update, version change, prep for v5.0.6rc1 #12914

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

janjust
Copy link
Contributor

@janjust janjust commented Nov 7, 2024

v5.0.x NEWS update. version change prep for rc1

bot:notacherrypick

@github-actions github-actions bot added this to the v5.0.6 milestone Nov 7, 2024
A new smoke test has been added to validate this behavior.
-Test and CI Additions: A smoke test was introduced for session management, also integrated into macOS GitHub CI to ensure stability across platforms.
-Multiple Init/Finalize Handling: Improvements to handling session multiple initializations and finalizations, addressing issues with parameter management and session destruction.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fundamentally good, wondering whether we should add in the Session Management Enhancements also a line about the fix to Waitall/Waitany/Testall/Testany regarding the recognizing requests from the same instance. (see PR #12711)

@rhc54
Copy link
Contributor

rhc54 commented Nov 7, 2024

Question: given that you have a self-maintained fork of PRRTE that you use for your main branch, do you need to specify the repo you are using when you cite the hash for PRRTE? Guess that could apply to any submodule, though PRRTE is the only one where there is immediate ambiguity.

@janjust janjust changed the title v5.0.x: NEWS update, prep for v5.0.6rc1 v5.0.x: NEWS update, version change, prep for v5.0.6rc1 Nov 7, 2024
@janjust
Copy link
Contributor Author

janjust commented Nov 7, 2024

@rhc54 good point - I think we could add that to correctly attribute where the hash is from

@janjust janjust force-pushed the v5.0.x branch 2 times, most recently from d2e8511 to 27a247d Compare November 7, 2024 17:39
@edgargabriel
Copy link
Member

In the VERSION file, I think we need to increment also

libmca_opal_common_ofi_so_version

because of this commit here: #12882
(if I understand the logic correctly)

@janjust janjust force-pushed the v5.0.x branch 3 times, most recently from b8f09a4 to 92da2f7 Compare November 7, 2024 20:18
bot:notacherrypick

Signed-off-by: Tomislav Janjusic <[email protected]>
bot:notacherrypick

Signed-off-by: Tomislav Janjusic <[email protected]>
@janjust janjust merged commit 7902b14 into open-mpi:v5.0.x Nov 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants