feat: add glob pattern support for --namespace flag #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for glob-style wildcards (*, ?, [...]) in the --namespace flag, allowing users to match multiple namespaces with patterns like "main.*" or "*.gke". Fixes open-policy-agent#1141 Signed-off-by: majiayu000 <[email protected]>
Rename "Test command with namespace wildcard pattern" to "Test command with namespace exact match" since it tests exact namespace matching without wildcards. Signed-off-by: majiayu000 <[email protected]>
jalseth
requested changes
Jan 11, 2026
Member
jalseth
left a comment
jalseth
left a comment
There was a problem hiding this comment.
Thanks for taking on this PR. Can you also add support to this for the verify command?
| // filterNamespaces filters the available namespaces using the given patterns. | ||
| // Patterns support glob-style matching with *, ?, and [...] syntax. | ||
| func filterNamespaces(available []string, patterns []string) []string { | ||
| seen := make(map[string]bool) |
Member
There was a problem hiding this comment.
I don't think this is necessary. engine.Namespaces() returns the unique list already.
| } | ||
| matched, err := path.Match(pattern, ns) | ||
| if err != nil { | ||
| continue |
Member
There was a problem hiding this comment.
This should raise an error rather than silently continuing.
| } | ||
| } | ||
|
|
||
| func TestFilterNamespaces(t *testing.T) { |
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { |
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { |
| "testing" | ||
| ) | ||
|
|
||
| func TestHasWildcard(t *testing.T) { |
| return files, nil | ||
| } | ||
|
|
||
| // hasWildcard checks if any of the given patterns contain wildcard characters. |
Member
There was a problem hiding this comment.
Please add a note that this is based on what path.Match() supports.
| } | ||
|
|
||
| // filterNamespaces filters the available namespaces using the given patterns. | ||
| // Patterns support glob-style matching with *, ?, and [...] syntax. |
Member
There was a problem hiding this comment.
Please add a note that this is based on what path.Match() supports.
| // Patterns support glob-style matching with *, ?, and [...] syntax. | ||
| func filterNamespaces(available []string, patterns []string) []string { | ||
| seen := make(map[string]bool) | ||
| var result []string |
Member
There was a problem hiding this comment.
nit: Call this namespaces rather than a generic variable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1141
Changes